Print.js icon indicating copy to clipboard operation
Print.js copied to clipboard

print is async(). In Firefox, cleanUp was resulting in a blank print preview page. …

Open scottgroovez opened this issue 4 years ago • 4 comments

…This small delay fixes it.

scottgroovez avatar Feb 16 '21 11:02 scottgroovez

Pull Request Test Coverage Report for Build 338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.241%

Totals Coverage Status
Change from base Build 328: 0.0%
Covered Lines: 239
Relevant Lines: 363

💛 - Coveralls

coveralls avatar Feb 16 '21 11:02 coveralls

Just a comment from a complete outsider and maybe just personal preference but I think it would be good to add a comment in the code (basically the same as the PR description). That way it is way easier to understand why the delay is present even without using git blame or github.

FelixSchwarz avatar Feb 24 '21 08:02 FelixSchwarz

hi ... I am just commenting for this purpose that The issue which is coming in the Firefox, the file is previewing with the blank page in the Firefox browser How much time it take to resolve the issue

abdullah-tahir-exodevs avatar Jun 12 '23 10:06 abdullah-tahir-exodevs

hi ... I am just commenting for this purpose that The issue which is coming in the Firefox, the file is previewing with the blank page in the Firefox browser How much time it take to resolve the issue

this pull request is not working . I tried it in my project but is not working

abdullah-tahir-exodevs avatar Jun 19 '23 07:06 abdullah-tahir-exodevs