github-dark
github-dark copied to clipboard
cquanu
Fix read notifications
What's the issue:
When clicking on a notification or viewing read notifications (https://github.com/notifications/read), they appear bright.
What's fixed:
Fixes the above issue by changing the background of the notification items to be darker. I used #999 for the text color because secondary-text-color was too dark.
Screenshots:
Before:
After:
Hmm, not completely a fan of the colors, but I'm unable to find any more suitable ones right now. You're right that the --secondary-text-color is too dark. But maybe we should instead change the background color of the items? Maybe use --depth-color instead?
I updated the background color as suggested, let me know if there is anything more you would like for me to change.
Well I was actually asking for feedback 😅 Do you think that's a better color?
Ah, my mistake. I originally chose --accent-color because it is the same color as the bar that displays the repo name (which is how the github default style does it as well as shown in screenshot), but I think either color would work perfectly fine.
ah, that's a good point about the default... hmm.... Let me think about this for a bit.