ontime icon indicating copy to clipboard operation
ontime copied to clipboard

Draft: Feature - Edit multiple events

Open biancahpp opened this issue 2 months ago • 3 comments

biancahpp avatar Apr 08 '24 18:04 biancahpp

[!IMPORTANT]

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

235 files out of 297 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 08 '24 18:04 coderabbitai[bot]

Also, I'm not sure why, but it takes a little while for the UI to update after I select more than one event (using ctrl).

biancahpp avatar Apr 08 '24 18:04 biancahpp

Hi Bianca, can you send me an example of a rundown with poor performance? I tried investigating and everything seemed sensible to me

When a new event is selected, we need to re-render all the wrappers (to show the selection outline) and the event editor This seems expected? I was also unable to verify any major performance issues. Granted that my rundown has 14 elements, but a full re-render is hitting 30ms Screenshot 2024-04-27 at 11 20 40

I have tried adding 200 elements and the render seemed to reach up to 60ms, which is not ideal but still not prohibitive What do you think?

cpvalente avatar Apr 27 '24 09:04 cpvalente