ontime icon indicating copy to clipboard operation
ontime copied to clipboard

Scale message to fit in Timer

Open cpvalente opened this issue 1 year ago • 2 comments

The issue

Currently, the timer view shows the messages from the Editor in a fixed size. This means that, with enough text content, the view overflows and the messages are not readable.

too much stuff in timer

Since this is screen specific, there is no way for the editor to know of the overflow, which makes matters worse

The task

The issue task is to modify the message display to always fit the message on the screen

Follow here for the code entrypoint We also have a copy of useFitText which could potentially be used here

cpvalente avatar Jun 11 '24 19:06 cpvalente

Clarification: the text should always fit the screen regardless of how many words it contains. If it contains too many words, the text size should be resized until it can fit the screen. Does that sound correct?

Is there a limit to the characters? What if someone pastes the entirety of War and Peace?

asharonbaltazar avatar Jun 25 '24 13:06 asharonbaltazar

Clarification: the text should always fit the screen regardless of how many words it contains. If it contains too many words, the text size should be resized until it can fit the screen. Does that sound correct?

Is there a limit to the characters? What is someone pastes the entirety of War and Peace?

Hi!

Yes. We should make sure that the text always takes the whole size to fit. The text should be able to break lines as needed though

We don't enforce limits. We likely will need (and want) upper and lower limits on font-size for the algorithm. War and peace might not workout...

I think any reasonable defaults are good enough. If we don't have anything in mind something between 16px-128px sounds good to me

cpvalente avatar Jun 25 '24 15:06 cpvalente

Done and released in v3.5.0

cpvalente avatar Oct 05 '24 08:10 cpvalente