react-actioncable-provider icon indicating copy to clipboard operation
react-actioncable-provider copied to clipboard

Published 20 hours ago • verified publisher icon cpunion

Re-wrote Component to be more modern

Open jediofthecode opened this issue 6 years ago • 5 comments

I re-wrote the base Provider component to use the more modern syntax. I also re-write the <ActionCable> component completely, to be a HOC instead. I also improved the build process of the plugin itself. The build process requires some review, I used the install hook, but i believe it is better to use the prepare hook instead. This require update of the documentation as well, I can do this when i have a bit more free time.

To Do:

  • Rewrite new tests to adhere to new plugin structure
  • Update documentation to coincide with the new usage, and provide more detailed API usage

jediofthecode avatar Apr 24 '18 13:04 jediofthecode

This requires a bit more work, but I made the PR to propose the new structure. Otherwise, I have package this as react-actioncable-provider-next for testing

jediofthecode avatar Apr 24 '18 15:04 jediofthecode

All the requested changes have been made, and some additional improvements that were necesary. This should also fix #12

jediofthecode avatar Apr 26 '18 12:04 jediofthecode

Thanks! I will review and test later.

cpunion avatar Apr 27 '18 14:04 cpunion

Thanks for your great work. That's big changes, I need more time to test.

cpunion avatar May 01 '18 02:05 cpunion

Sorry for the delay, i have been quite busy. I will try and get these changes in this, and I made some other fixes in the mean time that were crucial.

jediofthecode avatar May 15 '18 07:05 jediofthecode