Brian Goff
Brian Goff
@fuweid Did you have a branch with this work?
I looked at this for Docker only. In Docker the issue was when there are log readers we can't complete a rotate. What we ended up doing is making sure...
Maybe you can add this to the agenda for the next community call? https://docs.google.com/document/d/1Q8KyVJd26oAQ3MafbnkVBgJCopPl2Bw45H9L9br9Vus/edit#heading=h.w85uown0afcu
We could probably wait for 2.0 for this (should be release after 1.7).
Having runc report it isn't bad, but I think in practice it is not very usable for this case. runc's update cycle is very different from higher level runtimes, so...
@jeanluclariviere What does it mean that "containerd is failling to pull" but "crictl works"? "crilctl" would be calling the cri API in containerd to do a pull.
@jeanluclariviere Still trying to understand in what context containerd is failing, because `crictl` *is* calling containerd (assuming you've configured it to do so and not something else).
I personally don't feel like image pull time is a very useful metric to track unless you are only ever pulling 1 image or multiple images of roughly the same...
Can you change the reference in your commit to the kubernetes/enhancements#2008? Right now it's referencing an unrelated containerd PR.
/test pull-containerd