Carson Sievert

Results 341 comments of Carson Sievert

[itables](https://github.com/mwouts/itables) is probably closest in terms of feature set, but Shiny also ships with it's own https://shiny.posit.co/py/components/outputs/data-grid/

bslib defaults to version 5.3.1 now. You have to specifically opt-in to 4.6.0 by doing `bs_theme(version = 4)`

Are you wanting to only set a different font family for the slider? If you want to do that more generally, I'd recommend this instead ```r library(bslib) page_fluid( theme =...

I think the ship has probably sailed at this point for accepting a string. We also do throw an informative error: ```r > bslib::page("bar", theme = "foo") Error in assert_bs_theme(theme)...

Ahh, right, that error only gets thrown when rendered statically. Otherwise, it gets passed to `shiny::bootstrapPage()`, which doesn't error. Maybe we should do more to throw earlier on.

Put the `class="overflow-auto"` on the `nav_panel()`, not inside an additional `div` -- [like this](https://shinylive.io/r/editor/#code=NobwRAdghgtgpmAXGKAHVA6ASmANGAYwHsIAXOMpMAGwEsAjAJykYE8AKAZwAtaJWAlAB0IdJiw71OY4RBEBXWgAIAPAFolqKAHM4AfWgA3ei3YilSo3q0Q41M2ACCQvEoLUonTgF4XRQ3CMAGbURADualDypEQuuEouAAo6cEqObiTkZHFKHqxE0XrE1PIwEHphzKjsBCwAJuyhjHAwiIi0qJyl7ABMAAwCgwK45pZQhtZQtvYuAEI5SSlKsxlkFKQuw6NWNnYOAMILYMm6SvurWRtgWxAWpLSk1KneCU7oSmEP3GPGLHGjtDqSheLi0un+tyUQSIRHIjGBrxgrChMLhEIsQVo1A89CeCIAKlgAKoAUREshEnECAXh6ih8ggBHuJHYfFQ0XiBVI7NIAiUIBEIgAvoKIDw+KxHOh2IoEYp4lTGDSEYqabIwEKALpAA)

Nice! I'd like to have one more closer look before merging, but consider this basically approved. Let me know when you're ready to merge, and I'll have one more closer...

One subtle issue I noticed in testing -- if you make the window small (to go in mobile mode), then big again (to desktop mode), the resize handle is no...

Yea, I can repro on [4ec6428](https://github.com/rstudio/bslib/pull/1217/commits/4ec6428e18fb91c9713c93f545ed889921b7bb08) with this example: ```r library(bslib) library(shiny) library(crosstalk) library(plotly) library(leaflet) # Creates the "filter link" between the controls and plots dat add_histogram(x = ~cut, color...