Carson Sievert

Results 294 comments of Carson Sievert

Some insight thanks to Sameer Deshpande: > I don't remember exactly the cut-off, but I think the XML data is not available for games after the middle of February >...

I like your last solution best (how would `tablewidth` be different from `wraptablewidth`?)

> I asked @cpsievert to have a look and give its thoughts on this one. We need to think this through correctly on what it is supposed to be. I...

There's a work in progress here https://github.com/ropensci/plotly/pull/813

Similarly, foreground colors are also hard-coded. Here's just one example: https://github.com/samhogg/histoslider/blob/1d0f1b01eb81309a8dd0b227ef899570f6beb1c4/src/components/Slider.js#L186 It'd be better if the foreground colors defaulted to `currentColor`

This is probably the same thing as https://github.com/plotly/plotly.R/issues/2353#issuecomment-2124953001

> The default argument of "auto" didn't seem to do anything. That seems like a bug. If you can pinpoint the reason why it doesn't do anything, a issue/PR in...

Thanks @JohnCoene, would you mind looking into the test failures (and fixing them)?

@JohnCoene I noticed https://github.com/rstudio/shiny/pull/3996#discussion_r1526444684 when having a look into modifying one of our testing apps to account for this feature. I've got a start on that here https://github.com/rstudio/shinycoreci/pull/262 and it'd...

Thanks @JohnCoene, please add a NEWS item, then this should be good to merge. That said, it'd also be great to update our `158-input-labels` test to have test coverage of...