Carson Sievert

Results 193 comments of Carson Sievert

@hadley is there any reason why you've omitted this code to translate the data frame to css (which was in [this gist](https://gist.github.com/hadley/f53b6e92df20994fdabe6562d284728a) you shared with me previously)? ```r # https://github.com/jgm/skylighting/blob/a1d02a0db6260c73aaf04aae2e6e18b569caacdc/skylighting-core/src/Skylighting/Format/HTML.hs#L203...

Ok great, I'm currently thinking this wouldn't be `{bslib}`'s job anyway, but rmarkdown (or this pandoc package) would be responsible for translating a relevant `bs_theme()` into a pandoc highlighting theme...

Yea, after looking into it more, I don't think it's right for bslib to be including css, for a couple reasons: * I'm fairly sure, when opt-ing into pandoc syntax...

Also, it appears Firefox also wants to think that the `numericInput()` is some sort of password

Seems we could do something like this ```css input[type="number"]::-webkit-contacts-auto-fill-button { visibility: hidden; display: none !important; pointer-events: none; position: absolute; right: 0; } ``` https://stackoverflow.com/a/39885072/1583084

Does it work ok with this yaml? If not, it's might be because rpivotTable isn't compatible with Bootstrap 4? ``` --- output: html_document: theme: version: 4 --- ```

Actually, bs3compat itself is pretty heavy 😬 ```r bs_theme() %>% bs_remove("bs3compat") %>% bs_size() #> bootstrap.min.css 153618 ```

New layout helpers are certainly on our road map, and the development version just added [`layout_column_wrap()`](https://rstudio.github.io/bslib/articles/layouts.html#responsive-column-first-layout), which can be used to implement a "basic" sidebar layout, here's one such example...

Thanks for the report! For a temporary workaround, you can do: ```r bslib::bs_theme(5) %>% bslib::bs_add_rules(".popover-header { margin-top: 0}") ``` For posterity, I believe this is also a problem for accordions...