Carson Sievert

Results 294 comments of Carson Sievert

@hafen the dev version of ggplot2 is gonna be submitted to CRAN in a couple weeks. Looks like your relying on a lot of internals in https://github.com/hafen/trelliscopejs/blob/master/R/facet_trelliscope.R that have likely...

Could your issue be solved with something like `validate(need(nrow(table_data) > 0, "Waiting on data"))`?

Could you be more specific? Which script?

@GeoSot has this issue actually been fixed (it doesn't appear to be)?

@WinterSilence's comment does not resolve the issue and I cannot reopen it.

> Docs were then later strengthens to make it clear that it's not something that should be done. As a heavy user and follower of Bootstrap, I wasn't aware of...

> I'd prefer seeing this as a 3rd party extension/plugin, not a core feature. Then Bootstrap should be deprecating it first and intentionally removing it in a future major release....

> it was removed as part of the switch to 5.0.0 Is there any record/documentation of this? Also, in that case, why is there still this logic to toggle active...

@GeoSot I don't think that's necessary since, in the new implementation, by the time we reach `_toggleDropdown()`, the `.active` class will already be added/removed from the tab via https://github.com/twbs/bootstrap/blob/37e2e7e1249b0e514d6d07e3ee1bc01dbdc42c8d/js/src/tab.js#L103-L108 and...

You can set `options(shiny.useragg = FALSE)` to revert to the old behavior