SnapLinksPlus icon indicating copy to clipboard operation
SnapLinksPlus copied to clipboard

Filtering doesn't work properly on Reddit

Open i486 opened this issue 6 years ago • 5 comments

snaplink

Please see the attached screenshot. It says "4 Links" but if i let go of my mouse, everything in green box will be executed.

"Disable link filtering by font weight" is still unchecked.

i486 avatar Jun 22 '19 00:06 i486

Interesting, do you have a URL where this is happening? Also, you are not holding down the alt key, are you?

cpriest avatar Jun 22 '19 22:06 cpriest

Yes. I am not holding down the alt key because am not using any modifier. Only right click and drag. But i just tried it again with "Alt + Right Click" setting and result is same.

Here is the site

https://old.reddit.com/r/buildapcsales/

i486 avatar Jun 23 '19 00:06 i486

Any news?

i486 avatar Jul 01 '19 06:07 i486

I've diagnosed what's happening here:

image

Essentially, the small links (share/save/hide/report/crosspost) are of type 'Clickable' because they are javascript:void() links rather than ordinary links. In this case, when highlighting the title and those 'Clickable' javascript links, the GreatestOfType feature is kicking in and considering the Clickable count is higher.

I'm not sure of the best way to proceed in this case. As a workaround, if you can just highlight the main links that will open them up and ignore the javascript links for the time being.

I'll think about how to handle this more appropriately. It may be that I want to make <A> refs that are javascript: links be treated as just plain "Links" which would them subject them to the same font size/weight algorithm.

cpriest avatar Jul 01 '19 11:07 cpriest

Thanks for the response and explanations.

clicks

Do you mean like this? if yes then yeah it's a workaround I've been using for some time on Reddit :P

Hope you find the best way to fix this issue. Thanks!

i486 avatar Jul 02 '19 08:07 i486