SnapLinksPlus
SnapLinksPlus copied to clipboard
cpriest
Snap Links 3.1.2.4 coinciding or contending with the context menu
From https://github.com/cpriest/SnapLinksPlus/issues/228#issuecomment-401121197:
… a bug? Are you getting the contextual menu after you release the mouse button (and there is a green lasso on screen)?
With a preference for right-click and drag: the menu appears, as expected, when I right-click (not when I release) so I have both the menu and the lasso. Like this, for example:
– the lasso almost completely hidden beneath the menu.
contextual menu after you release
Is that a norm with some operating systems?
Environment
3.1.2.4 with Waterfox 56.2.1 on FreeBSD-CURRENT,
$ date ; uname -v
Thu 28 Jun 2018 19:21:49 BST
FreeBSD 12.0-CURRENT #5 r335024: Wed Jun 13 11:04:24 BST 2018 root@momh167-gjp4-hpelitebook8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC
$ pkg info waterfox | grep Version
Version : 56.2.1.19_2
Ah, I think SnapLinks 2 had some special code in place for Linux/Unix systems. They don't work the same with the context menu as windows (mac?).
Unfortunately, I cannot test this easily. What I can do though is look through the old code and try to replicate it's functionality and put it in the next beta release.
Hi, I have the same issue on Gnu/Linux system, very annoying and I had to add a modifier key to SLP to be able to browse without this problem. @cpriest If you don't use *nix system and want a testing environment you can just install something like ubuntu on a virtual machine (virtualbox). I hope this issue is solved soon as I can't browse without SLP
Regards
@cpriest sorry to ping you but any update on digging the old code ? I'm willing to test betas on *nix systems. Thanks
I haven't had any time to even think about this project, not sure if I will for the foreseeable future at the moment.
I'm going to post for some help w/ regards to this issue and some other similar issues, hopefully, I will find out a way to make this work properly.
Can you try this with the latest v3.1.6 release and LMK if there are still problems?
@cpriest Ok, I'm a bit confused, I've had the 3.1.6 version installed for a couple of weeks now, but looking at the commit log i see you just released the 3.1.6 a couple of hours ago ? the addons website also confirm that the 3.1.6 was released a month ago. Anyways, with the current 3.1.6 version(that was installed a month ago) I can see the same problem,no improvements.
Regards
Yes, there was some confusion on my part. I ran the web-ext build/release tool and the message it gave me lead me to believe it was not received/accepted. I only found out later that it had been released.
Thanks for the update, I'll keep this ticket open then.
What about totally deactivating default RightClic/ContextMenu behavior? In EndDrag we can open ContextMenu in the else statement:
https://github.com/cpriest/SnapLinksPlus/blob/be1312fe3d314e4cf72f48077bbd932d43cab97b/src/content-scripts/EventHandler.js#L193-L205
Doing that we can remove every other thing related to Context Menu like StopNextContextMenu or onStopContextMenu.
I'm not sure I follow what you mean? I guess if there is a different way to disable the next context menu from happening in some other way, I'm not aware of it.
One issue here is that on Linux platforms the contextmenu fires on mouse down and on others it fires on mouse up. Ergo we prevent it from happening until mouseup (if the mouse has moved far enough from its start point.
I read that and I suggest to prevent ContextMenu default action. Then SL3 has to take care of the opening of ContextMenu if CurrentSelection.IsLargeEnoughToActivate is false.
(Apologies for the silence from me. Following with interest, but my preferred version is 2.4.3 (with Waterfox Classic).)
@cpriest Any progress on this ? it's getting really annoying to browse and right click on links.
(Apologies for the silence from me. Following with interest, but my preferred version is 2.4.3 (with Waterfox Classic).) SnapLinks v2 is no longer under development, if you'd like to you're free to fork the repo and continue with v2.
@moham96 Sorry, no progress on this yet.
I didnt notice anybody say,'what is right click on a touch pad .Thought that would help in your tutorial. Which is cool that i got this on android.
While I still can't test this at the moment, the forthcoming 3.1.9 release does modify the behavior on mouse down by preventing the default action. Once that is released, please let me know if this issue still persists.
This bug is active again in the latest release (3.1.11)
It can be reproduced on a fresh new profile of 93b9
Someday/maybe, I don't have the time or interest in maintaining this project. It works the way I want it to. I'm open to pull requests and/or helping someone if they don't understand some part of the code.
@cpriest I know you indicated having no real interest in fixing this as the plugin works for your use-case. But if there is any progress on this, can you post an update here? A fix for this would be appreciated, but also see no one is posting a PR for this. Personally do not have this expertise so unfortunately cannot help either.
