[Feature request] Open links in separate window

[mystcdra101]

I click adoptables on places like Magistream and need to do what I was able to do before the 'Plus' came out. I need all the tabs to go into a separate window, so all I need to do is close the window when done and still have my other window open to click more. According to your description, this is supported, but I can't find anything in the add-on option menu that allows me to choose this.

Please fix this.

[hirnhopser]

I'm not sure if "enhancement" is the right label for this.

Basically, I specifically open a single page in a new window (let's call it window 2), and then on that page, use snaplinks to select a whole bunch of links, using delay. New tabs start to open in window 2, as they should.

However, as soon as I switch focus to the other browser window (window 1), all the new tabs get diverted to the currently active window 1 instead of window 2 where they should have gone. And the new tabs don't appear at the end of the tab bar (as defined in the options) either but rather to the left of the most recent active tab before starting the snapping process.

This does not feel like intended behaviour.

[remi-garcia]

https://github.com/cpriest/SnapLinksPlus/blob/9d9a85e81f032c0fea9db73d316b3a3253e5d563/src/background-scripts/background.js#L45-L61

I encounter this behavior too. Tabs are opened in the active window: browser. line 61. On MouseUp event, it might be possible to store the active window, then open tabs in this window. After that modification (to correct a bug), we could modify the code so opening links into a new window is possible as an option (which is the enhancement).

[remi-garcia]

I cannot test it right now but adding:

var activeWindow = browser.windows.getCurrent(); // Before line 45
activeWindow.tabs.create(props); // To replace line 59

might solve the issue @hirnhopser pointed out (or might not work at all, I have to check).

[sbehnken]

Did this ever work? I would also love to open links in a new window instead of tabs.

[mystcdra101]

I'm not on my laptop much anymore but it worked great in the past.

On Thu, Oct 7, 2021, 10:24 AM Seravin Behnken @.***> wrote:

Did this ever work? I would also love to open links in a new window instead of tabs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cpriest/SnapLinksPlus/issues/182#issuecomment-937844602, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGRW7OOF37GVUSLBPUSQN3UFWUSNANCNFSM4DTFVWAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[sbehnken]

What are the actions taken to open into a new window?

[cpriest]

It's not presently possible since the Web Extension version, the prior XUL based version had the capability. I have not (yet) added it to the web-ext version.