Dmitriy Kalinin

Results 407 comments of Dmitriy Kalinin

"Fetching resources: wait: no child processes" error from: - https://github.com/vmware-tanzu/carvel-kapp-controller/runs/6923327841?check_suite_focus=true#step:5:4575 - https://github.com/vmware-tanzu/carvel-kapp-controller/runs/7014548810?check_suite_focus=true#step:5:4402 ``` --- FAIL: Test_PackageInstallStatus_DisplaysUsefulErrorMessage_ForDeploymentFailure (11.16s) packageinstall_test.go:268: Expected useful error message to contain deploy error Got: Fetching resources: wait:...

(https://github.com/vmware-tanzu/carvel-kapp-controller/runs/7234570328?check_suite_focus=true) ``` --- FAIL: Test_PackageInstalled_FromPackageInstall_Successfully (6.51s) packageinstall_test.go:172: Error Trace: packageinstall_test.go:172 Error: Not equal: expected: v1alpha1.AppStatus{ManagedAppName:"", Fetch:(*v1alpha1.AppStatusFetch)(0xc000331ea0), Template:(*v1alpha1.AppStatusTemplate)(0xc000344f80), Deploy:(*v1alpha1.AppStatusDeploy)(0xc000331e30), Inspect:(*v1alpha1.AppStatusInspect)(0xc0001384b0), ConsecutiveReconcileSuccesses:1, ConsecutiveReconcileFailures:0, GenericStatus:v1alpha1.GenericStatus{ObservedGeneration:1, Conditions:[]v1alpha1.Condition{v1alpha1.Condition{Type:"ReconcileSucceeded", Status:"True", Reason:"", Message:""}}, FriendlyDescription:"Reconcile succeeded", UsefulErrorMessage:""}} actual...

Test_PackageInstall_UsesExistingAppWithSameName was fixed by #783

``` ==> deploy Running 'kapp deploy -f - -a test-repo-status-success -n kappctrl-test --yes --wait-timeout 3m'... ==> check against expected successful status Running 'kapp inspect -a test-repo-status-success --raw --tty=false --filter-kind=PackageRepository -n...

> The recommendation for the folder name could be "namespace+secretName" which secret are we talking about here?

> The recommendation for the folder name could be "namespace+secretName". If we do this may be different AppCR could reuse caching because they have the same credentials which means the...

since vendir could be used standalone (caching feature included) my rationale for `/apps//.vendir-cache/fetcher/imgpkgBundle//` location was: - `/apps//` is something that kapp-controller is responsible for configuring per App - `.vendir-cache/fetcher/imgpkgBundle//` is...

@nairb774 awesome, thanks for tracking that! ill try it out tomorrow.

> so I can't just update it to switch in an env var a common option here is to rely on ytt to transform the yaml so that it's more...

one possible feature addition i see here is that we could teach kbld to accept ytt functions as a way to deal with more complex input. at some point trying...