Josh Cooper
Josh Cooper
> TBH not sure if it's even a good wrapper... Just looked at the git blame.. So like, aren't you the primary dev of eventful? You'd know best if it's...
So having discussed testing in discord/#ci I think we could write a unit test for EventManager once #2109 is solid. As per the suggestion @lethosor gave (of just simulating event...
> 1: Let's do it at least as often as specified frequency but pass a ticks passed parameter at the end. -@wolfboyft I'd like to clarify this. Do you mean...
@warmist I believe this would require modification of the lua api integration point. Any idea how we'd pass the ticks? Could we get away with not touching the lua api,...
> These look good to me. Sorry, at least one more change to take a look at. Maybe another, not sure. I'n thinking about the fat collected in/around the command...
The command line improvements can wait for a second PR I think. It'll probably take me a long time to try out and weigh the options before I can pick...
> it would have been better in separate PRs Alright, I resorted things back to how they were.
Sounds like a simple way to avoid problems. Maybe I could additionally spend a bit of time and make comments about known life cycles in the managers.
Ok so I didn't put the comments in the managers, I thought it would make more sense to centralize the information to one location. So I put it with the...
So at some point in revising towards an ability to throw out stale id references I began refactoring various managers to share scan loops. Might be a week or two.....