travels icon indicating copy to clipboard operation
travels copied to clipboard

clang-tidy warnings for lesson 0 & 1

Open 0xBachmann opened this issue 3 years ago • 4 comments

consider adding '-readability-named-parameter' to the clang-tidy file, otherwise trying to build the project will fail for lesson 0 and 1 as there are a lot of unnamed parameters in those lesson. thanks for your work it is super fun to play around with your game

0xBachmann avatar Jul 07 '22 09:07 0xBachmann

Can you verify what clang-tidy you are using? many different versions run on several targets on the CI, and I'm not getting any of those failures.

lefticus avatar Jul 07 '22 10:07 lefticus

I use version 10 (x86_64-pc-linux-gnu) but just realized, that the problem occurred not with any of the lessons but with the game itself, only there are lambdas with unnamed parameters.

0xBachmann avatar Jul 08 '22 11:07 0xBachmann

I am facing the same issue when clang-tidy (LLVM version: 12.0.1) is checking game.cpp, game_components.cpp and all game hacking lesson files. Adding '-readability-named-parameter' to the clang-tidy file didn't fix the issue for me. So, I added '/unused/' in place of the unnamed parameters and it fixed it for me.

arun5309 avatar Jul 24 '22 14:07 arun5309

OK, I'll look into this this week. I just got back from a bunch of training and conference travel.

lefticus avatar Jul 24 '22 15:07 lefticus