cppbestpractices icon indicating copy to clipboard operation
cppbestpractices copied to clipboard

MSVC /Wall is not unusable because of standard library headers

Open laurynas-biveinis opened this issue 2 years ago • 0 comments

The current wording reads "/Wall - Also warns on files included from the standard library, so it's not very useful and creates too many extra warnings." – this reason does not seem to hold, because /external (i.e. /external:anglebrackets) exists and is effective in preventing /Wall warnings in the standard headers too.

A better reason to avoid /Wall would be a large number of informational diagnostics (i.e. https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4711?view=msvc-170) - but then again, these can be disabled individually.

laurynas-biveinis avatar Mar 07 '22 07:03 laurynas-biveinis

I did a PR about this (#146) but no one commented on it.

ifarbod avatar May 13 '22 21:05 ifarbod