cmake_template icon indicating copy to clipboard operation
cmake_template copied to clipboard

Linker.cmake should use target_link_options instead of target_compile_options

Open CramBL opened this issue 2 years ago • 0 comments

https://github.com/cpp-best-practices/cmake_template/blob/d19d8921771ba582824948f0cc57f849a5c6efd8/cmake/Linker.cmake#L29

From my understanding target_compile_options can be replaced by the more appropriate target_link_options.

Motivation

Functionally there's no difference, but adding linker-specific flags to the compilation step will raise warnings e.g. clang: error: argument unused during compilation: '-fuse-ld=mold' [-Werror,-Wunused-command-line-argument] in certain setups.

Example from CI in a project of mine. Treating warnings as errors means this harmless warning caused CI to fail.

Using target_link_options resolved it.

Thank you for sharing and maintaining this template project, it is a tremendous help!

CramBL avatar Oct 21 '23 18:10 CramBL