cmake_conan_boilerplate_template icon indicating copy to clipboard operation
cmake_conan_boilerplate_template copied to clipboard

Align docs and dependencies

Open lefticus opened this issue 2 years ago • 5 comments

  • [x] upgrade project_options
  • [ ] consider forking project_options
  • [x] update cmake version required
  • [x] check documents for required compilers/C++ verison

lefticus avatar Apr 01 '22 03:04 lefticus

Note @ddalcino this is based onto develop so it can easily be fully vetted before merging.

lefticus avatar Apr 01 '22 03:04 lefticus

Codecov Report

Merging #18 (c0f0f5b) into develop (f37c1ab) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #18   +/-   ##
========================================
  Coverage    77.77%   77.77%           
========================================
  Files            3        3           
  Lines           36       36           
  Branches        19       19           
========================================
  Hits            28       28           
  Misses           7        7           
  Partials         1        1           
Flag Coverage Δ
Linux 37.03% <ø> (ø)
Windows 80.00% <ø> (ø)
macOS 38.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f37c1ab...c0f0f5b. Read the comment docs.

codecov-commenter avatar Apr 01 '22 05:04 codecov-commenter

According to https://en.cppreference.com/w/cpp/compiler_support, there are still C++20 features that are as yet unsupported by clang. GCC 11 and the current release of Visual Studio 2019 both have full support for C++20.

It's possible that earlier versions of clang, GCC, and MSVC can successfully compile cpp_boilerplate_project. However, I think it's disingenuous to tell our users that an older version will work when they start using C++20 features that aren't demonstrated in the project.

It is my contention that we are already testing the oldest compilers that are compatible with the project; we just need to update the README to reflect the new versions.

ddalcino avatar Apr 01 '22 05:04 ddalcino

Is there anything left to do here?

Do we really need to fork project_options? Honestly, I don't see a pressing need to do so at the moment. I am tempted to just watch and wait until something breaks.

ddalcino avatar Apr 07 '22 00:04 ddalcino

Whoa, that merge really didn’t work out. I’m not clear on what happened to Visual Studio, and I really wasn’t expecting the template janitor to fire. Any ideas here?

ddalcino avatar Apr 30 '22 21:04 ddalcino