Latest Commit Breaks ESP32 Functionality

[jdtsmith]

I can connect just fine, and can see output echoed that I enter directly through a serial connection, but input does not echo not come through. Has this been seen?

[jdtsmith]

Further info: as mentioned in this issue, dupterm_notify is required for the ESP32 to read from dupterm. The last commit here comments that out, which means this no longer functions on ESP32. I simply commented this line back in and it fixed it:

    last_client_socket.setsockopt(socket.SOL_SOCKET, 20, uos.dupterm_notify)

[mchobby]

will double check and find a elegant solution

[MarSoft]

I think elegant solution would be to try dupterm_notify and catch errors. Or check its availability, like this:

if hasattr(uos, 'dupterm_notify'):
    last_client_socket.setsockopt(socket.SOL_SOCKET, 20, uos.dupterm_notify)

[geomatik]

I can confirm the same problem with ESP-01 (1MB). The firmware is "esp8266-20190529-v1.11.bin". I can see the output of direct serial connection from telnet client. But input from telnet client does not come out.

[gkzsolt]

I can confirm @jdtsmith's reported problem on an ESP32-Mini32. I installed esp32-idf3-20200902-v1.13.bin, and input does not echo not come through. After commenting back line 78, with uos.dupterm_notify, telnet kind of works, but input is echoed (with the response) only after hitting Enter.