gosl icon indicating copy to clipboard operation
gosl copied to clipboard

Fix shadowed iterator variable in GaussLegendreXW

Open ejanzer opened this issue 4 months ago • 1 comments

The for loop in GaussLegendreXW initializes an iterator variable it that shadows a previously declared it outside the loop. The outer it is compared to MAXIT, but because it's shadowed it's never updated, so the panic will never be triggered if it did not converge.

A linter surfaced this issue for me. I don't know how to test it, though...

ejanzer avatar Aug 07 '25 21:08 ejanzer

Hi, thanks for the fix. Testing this case it's tricky because we need to find a failing problem. But don't worry, I'll work on this in the upcoming weeks. Thanks again.

cpmech avatar Aug 07 '25 23:08 cpmech