monospacifier icon indicating copy to clipboard operation
monospacifier copied to clipboard

Update monospacifier.py

Open PatienceAllergy opened this issue 3 years ago • 4 comments

Due to a potential bug in font-forge, the right/left side glyph bearings need integers, despite error messages claiming to need floats.

PatienceAllergy avatar Jun 28 '22 05:06 PatienceAllergy

Please help to add that this pull request will close #32 in your PR description, so that the issue will be automatically closed when this PR is merged. :+1:

win98se avatar Jun 30 '22 02:06 win98se

Using math.round() returns an error that reads AttributeError: module 'math' has no attribute 'round'; Changing it to round() (without math.) solves it.

You're right! I tested it, and it built a font, but I didn't notice the error!

It works perfectly without the "math." Now let's see how I can update this thing...

PatienceAllergy avatar Jul 03 '22 13:07 PatienceAllergy

Now let's see how I can update this thing...

Just push an update to your fork and this PR will be updated as well. ;)

win98se avatar Jul 03 '22 13:07 win98se

Now let's see how I can update this thing...

Just push an update to your fork and this PR will be updated as well. ;)

It looks like somehow I did that, not sure how, but yay!

PatienceAllergy avatar Jul 03 '22 13:07 PatienceAllergy