biblio.el icon indicating copy to clipboard operation
biblio.el copied to clipboard

Published 20 hours ago • verified publisher icon cpitclaudel

Make timeout configurable

Open leezu opened this issue 3 years ago • 2 comments

biblio-url-retrieve hardcodes a timeout.

https://github.com/cpitclaudel/biblio.el/blob/39c362b9eb36e8c00efb5aa6ed406ef8c6a2e2ac/biblio-core.el#L209-L217

Accessing google-scholar via biblio-gscholar.el from https://github.com/nchodosh/biblio.el/commit/1c532b5b6ce73124aa579cf2c0540c429da00bb1 will often take longer than 1 second and trigger the timeout.

leezu avatar Dec 01 '20 00:12 leezu

Good point, thanks! I will look into preparing a patch, unless you're interested in making a PR?

cpitclaudel avatar Dec 01 '20 00:12 cpitclaudel

I'm fine with you preparing the patch. It may cost you less time given your familiarity with the codebase. Thank you for looking into it :)

leezu avatar Dec 01 '20 17:12 leezu