usaco-guide icon indicating copy to clipboard operation
usaco-guide copied to clipboard

Alternate Solution (https://usaco.guide/silver/func-graphs?lang=java#example---badge)

Open abhideepd opened this issue 1 year ago • 1 comments

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request. Updating the changes, as per the comments in this pr: #4335

  • [x] I have tested my code.
  • [x] I have added my solution according to the steps here.
  • [x] I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • [x] I have linked this PR to any issues that it closes. #4330

abhideepd avatar Feb 22 '24 07:02 abhideepd

bro why'd u close the other pr

SansPapyrus683 avatar Feb 22 '24 14:02 SansPapyrus683

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Mar 05 '24 09:03 stale[bot]

bro why'd u close the other pr

Did it by mistake. Please ignore the previous pr. I have updated this pr, with the relevant changes.

abhideepd avatar Mar 06 '24 21:03 abhideepd

im not sure if this is different enough of a solution to justify another section. maybe an info section would be better

bump on kevin's comments too!

This approach is a bit different, kind of a variation. I feel, including multiple approaches and variations to a solution, helps the reader, achieve more clarity of the concepts. Also, this area is collapsible, so it wouldn't hamper the ui aesthetic of the website 😬

abhideepd avatar Mar 06 '24 22:03 abhideepd

im not sure if this is different enough of a solution to justify another section. maybe an info section would be better bump on kevin's comments too!

This approach is a bit different, kind of a variation. I feel, including multiple approaches and variations to a solution, helps the reader, achieve more clarity of the concepts. Also, this area is collapsible, so it wouldn't hamper the ui aesthetic of the website 😬

well, conceptually it's the same right? using floyd to find cycles + filling up the other nodes.

i still think it'd be better as:

<solution 2 code>

It's also possible to use floyd(x) to generate answers for all vertices in the connected component containing x without using adjacency lists. We can do this by ...

<psuedo code of fill_up function>

if @SansPapyrus683 thinks it's fine as it is then that's okay too

ryanchou-dev avatar Mar 09 '24 22:03 ryanchou-dev

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Mar 18 '24 03:03 stale[bot]