usaco-guide
usaco-guide copied to clipboard
Implement Discussion Based Suggestions
Resolves #2650
If any of the below doesn't apply to this Pull Request, mark the checkbox as done.
- [x] I have tested my code.
- [x] I have added my solution according to the steps here.
- [x] I have followed the code conventions mentioned here, which includes the following:
- I understand that if it is clear that I have not attempted to follow these guidelines (ex. if I have not used tabs to indent), my PR will be closed.
- If changes are requested, I will re-request the review after making them.
yooooo tysm!!
hmm, can you link me to the docs for the discussions endpoint that you're using? afaik there's no way to use the rest api to create discussions, you have to use the graphql api
Sorry I meant to leave this as a draft pr.
yooooo tysm!!
Give me like a day or two and It'll be done.
@maggie-j-liu This code should work as I tested in on the gh API explorer but I'm not completely sure if the process.env.GITHUB_ACCESS_TOKEN
will work for discussion creation.
@apollo/client
bundle size is pretty massive -- is there any way of creating a discussion without using that package (or any new package ideally)?
wait just kidding -- this runs on firebase functions so bundle size isn't a (big) concern
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
hey uh how's this going?
I haven't gotten a review yet
@thecodingwizard @maggie-j-liu please
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
For some reason I keep getting this error when committing my changes so I have to edit the file directly on github
@MrinallU try git commit --no-verify
(with the --no-verify
flag) to skip the hook
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
Changes requested have not been made. Free free to create a new PR.
so uh how's this going?
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
Changes requested have not been made. Free free to create a new PR.
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
Changes requested have not been made. Free free to create a new PR.
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!
Changes requested have not been made. Free free to create a new PR.