usaco-guide icon indicating copy to clipboard operation
usaco-guide copied to clipboard

Implement Discussion Based Suggestions

Open MrinallU opened this issue 2 years ago • 16 comments

Resolves #2650

If any of the below doesn't apply to this Pull Request, mark the checkbox as done.

  • [x] I have tested my code.
  • [x] I have added my solution according to the steps here.
  • [x] I have followed the code conventions mentioned here, which includes the following:
    • I understand that if it is clear that I have not attempted to follow these guidelines (ex. if I have not used tabs to indent), my PR will be closed.
    • If changes are requested, I will re-request the review after making them.

MrinallU avatar Jun 17 '22 15:06 MrinallU

yooooo tysm!!

SansPapyrus683 avatar Jun 17 '22 21:06 SansPapyrus683

hmm, can you link me to the docs for the discussions endpoint that you're using? afaik there's no way to use the rest api to create discussions, you have to use the graphql api

maggie-j-liu avatar Jun 18 '22 03:06 maggie-j-liu

Sorry I meant to leave this as a draft pr.

MrinallU avatar Jun 18 '22 04:06 MrinallU

yooooo tysm!!

Give me like a day or two and It'll be done.

MrinallU avatar Jun 18 '22 04:06 MrinallU

@maggie-j-liu This code should work as I tested in on the gh API explorer but I'm not completely sure if the process.env.GITHUB_ACCESS_TOKEN will work for discussion creation.

MrinallU avatar Jun 18 '22 08:06 MrinallU

@apollo/client bundle size is pretty massive -- is there any way of creating a discussion without using that package (or any new package ideally)?

thecodingwizard avatar Jun 21 '22 23:06 thecodingwizard

wait just kidding -- this runs on firebase functions so bundle size isn't a (big) concern

thecodingwizard avatar Jun 22 '22 08:06 thecodingwizard

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Jun 30 '22 02:06 stale[bot]

hey uh how's this going?

SansPapyrus683 avatar Jun 30 '22 02:06 SansPapyrus683

I haven't gotten a review yet

MrinallU avatar Jun 30 '22 04:06 MrinallU

@thecodingwizard @maggie-j-liu please

SansPapyrus683 avatar Jun 30 '22 04:06 SansPapyrus683

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Jul 07 '22 04:07 stale[bot]

err

For some reason I keep getting this error when committing my changes so I have to edit the file directly on github

MrinallU avatar Jul 09 '22 20:07 MrinallU

@MrinallU try git commit --no-verify (with the --no-verify flag) to skip the hook

maggie-j-liu avatar Jul 09 '22 21:07 maggie-j-liu

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Jul 17 '22 02:07 stale[bot]

Changes requested have not been made. Free free to create a new PR.

stale[bot] avatar Jul 24 '22 03:07 stale[bot]

so uh how's this going?

SansPapyrus683 avatar Sep 24 '22 22:09 SansPapyrus683

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Oct 02 '22 00:10 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Oct 10 '22 01:10 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Oct 17 '22 16:10 stale[bot]

Changes requested have not been made. Free free to create a new PR.

stale[bot] avatar Oct 25 '22 00:10 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Nov 01 '22 01:11 stale[bot]

Changes requested have not been made. Free free to create a new PR.

stale[bot] avatar Nov 08 '22 04:11 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

stale[bot] avatar Nov 15 '22 08:11 stale[bot]

Changes requested have not been made. Free free to create a new PR.

stale[bot] avatar Nov 22 '22 13:11 stale[bot]