Corentin Cadiou

Results 86 comments of Corentin Cadiou

> @cphyc thanks for the fix! > > I'm game for this going in; the perf does not seem to be a big deal, and is likely swallowed up by...

> Yes, but I did not write down the numbers. Will attempt to do some perf comparisons asap. yt.visualization.volume_rendering.tests.test_mesh_render.test_surface_mesh_render goes from 3.8746s to 7.9495s with this PR!

> > Yes, but I did not write down the numbers. Will attempt to do some perf comparisons asap. > > yt.visualization.volume_rendering.tests.test_mesh_render.test_surface_mesh_render goes from 3.8746s to 7.9495s with this PR!...

I'm ok in principle, but I would like to have some robust performance test (esp. for volume rendering) before merging.

Note: this is a Cython bug, which has been reported upstream (see https://github.com/cython/cython/issues/4313) and there is an open PR to fix this as well (https://github.com/cython/cython/pull/4315).

I seem to remember we already had this discussion but I cannot find it anymore. Was it on the mailing list? Maybe here https://mail.python.org/archives/list/[email protected]/message/7E5A4WGVTRAUMVYXOEPHZO5TTE7JWYTQ/?

The issue is due to a buggy detection of interactive / non interactive shell. Maybe I should remove it to make the code more simple but then it means that...

Is there any update w.r.t. to this issue?

@BlazJurisic this also works for me! However I had to skip the `jQuery.noConflict()` part, otherwise `jupyter-notify` can't find the symbol `$` (jQuery's object). I did exactly this: ```python # Cell...