carp.sensing-flutter icon indicating copy to clipboard operation
carp.sensing-flutter copied to clipboard

[carp_esense_package] Status is not updated when sampling data

Open luciamontesinos opened this issue 3 years ago • 1 comments

deviceStatus is not being updated when eSenseStream is listening for events. I'm not sure if the status should be updated always (including when it's a BatteryRead event) or only when there is the proper data sampling (ESENSE_BUTTON and ESENSE_BUTTON)

Therefore, missing adding status = DeviceStatus.sampling; below

https://github.com/cph-cachet/carp.sensing-flutter/blob/e7d8981a970e434eeac84b7e7bd1a8e7b52c1394/packages/carp_esense_package/lib/esense_device_manager.dart#L105-L128

luciamontesinos avatar Apr 06 '22 14:04 luciamontesinos

The status sampling has been removed in version 0.40.0. It makes little sense to have this status, since a device is serving several "probes" (like both the eSense button and events probes), and it is hard to determine the semantics of when a device is sampling -- this is the probe which have this status (which is called resumed).

bardram avatar May 25 '22 14:05 bardram

Released with version 0.40.0.

bardram avatar Sep 25 '22 21:09 bardram