Phillip Cloud
Phillip Cloud
Wow, I am surprised that only 2 backends failed with this enabled!
@CyborgPotato It looks like the macos build is failing.
Closing in favor of #1621.
Benchmarking against `main`, there's anywhere from ~0-2.5x speed up on every benchmark. Benchmarks: ``` ------------------------------------------------------------------------------------- benchmark 'test_big_eq_expr': 2 tests -------------------------------------------------------------------------------------- Name (time in ns) Min Max Mean StdDev Median IQR...
Makes sense. It seems like that might not be representative of an actual workload though.
In any case a perf improvement + 10k fewer lines of code seems like an great improvement!
Seems like we can delete some of these fully-commented out test modules.
Thinking about this some more, I think we want to keep the pattern system inside Ibis for now. While the performance gains are nice, the development overhead of developing two...
Closing this out for now.
We can't get rid of mutability as a contract, as most or all of the internals rely on immutability for hashing purposes. However, we might be able to change the...