Phillip Cloud comments

Results 993 comments of


                                            Phillip Cloud

feat: make `name` param optional to create_table()

I'm not sure we ever discussed this, but what about a `con.memtable` method, allowing you to choose which backend a memtable goes into, which would allow `.cache()` to make sense.

feat: better api for creating aggregates over scalars

Hm, yeah. One weird thing here is that adding aggregate methods to scalars sort of obviates the need for scalars and columns, since they now just become special cases of...

feat(strings): `len_bytes` and `length` for string columns

Here's a table of how our backends handle computing the length of the string `🤦‍♂️🤦‍♀️`. It will surprise no one that not every backend we support agrees on this string's...

feat(strings): `len_bytes` and `length` for string columns

The upshot here is that we can't make any strong guarantees about what is returned across backends for string operations that depend on a notion of "character", **even when encoding...

feat(strings): `len_bytes` and `length` for string columns

Yep, sounds good to me. Slight preference for `byte_length` over `len_bytes` or `length_bytes`, *OR* deprecating `length` in favor of `len` and adding `len_bytes` or `byte_len`.

feat(strings): `len_bytes` and `length` for string columns

Actually, I hate `byte_len`, so scratch that one from my suggestion list.

Ibis-Athena: Dataset error while using save_dataset.save(data)

Thanks for the issue! What is `TableDataset`? Are you using another library on top of Ibis here? Also, Ibis 3.3.0 is not a version of Ibis that exists. You probably...

feat: perform DDL not in a transaction where possible

Can't you use the `Backend.begin()` method for this? Or does that not work?

refactor(dask): remove the dask backend

This PR is open for discussion, just to have something to anchor discussions. Just because there's a PR doesn't mean it will be merged.

refactor(dask): remove the dask backend

Lint failures are related to the `BREAKING CHANGE` bit. I will fix those up if we decide to merge this.