Phillip Cloud

Results 993 comments of Phillip Cloud

Probably related to this equality: ``` In [7]: s1 = ibis.schema(dict(a="int", b="string")) In [8]: s2 = ibis.schema(dict(b="string", a="int")) In [9]: s1 == s2 Out[9]: True ```

It looks like you've branched into `ibis-project`. This needs to be recreated as a PR coming from your fork.

I think this is too close to the release to get it in for 9.0. We'll probably need to do another non-major release a week or two afterward, so let's...

We have a `DayOfWeek` class defined in `ibis/expr/types/temporal.py`. It's a bit of an oddball API in that it functions like a namespace instead of top level method like everything else....

Here's a usage example: ``` In [8]: t = ibis.read_parquet("/data/avg_duration_over_time.parquet") In [9]: t.head() Out[9]: ┏━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓ ┃ date ┃ avg_duration_m ┃ ┡━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩ │ date │ float64 │ ├────────────┼────────────────┤ │ 2024-04-16 │...

Alternatively, I can take a crack at this one, if you want to handle `iso_year()`

@kaijennissen You should be able to find the tests that run across backends in `ibis/backends/tests/test_temporal.py`: ``` ❯ rg test_day_of_week ibis/backends/bigquery/tests/unit/test_compiler.py 72:def test_day_of_week(case, dtype, snapshot): ibis/backends/impala/tests/test_client.py 202:def test_day_of_week(con): ibis/backends/tests/test_temporal.py 1463:def test_day_of_week_scalar(con,...

Yeah, not sure entirely what's happening there.

Closing this out for now. Will put up another one after I have the nix macos setup working.

Created a notebook in a gist showing the issue: https://gist.github.com/cpcloud/b019ed898312d422190152b02b029377.