Phillip Cloud

Results 993 comments of Phillip Cloud

Thanks for raising the issue! I think adding this argument makes sense. I wonder if click has a way to just dump everything beyond `--` to a subcommand.

Not that I am aware of, I just haven't had the need to do that yet. Happy to look into it.

Another approach might be to use [`std::borrow::Cow`](https://doc.rust-lang.org/std/borrow/enum.Cow.html). Specifically, `Cow

@ali2992 Can you provide the schema that you used to benchmark?

This is not possible for an arbitrary Rust `enum`. Rust `enum`s are more generic than C-style `enum`s: each variant can contain arbitrary data.

Having both would be another option, slight preference for changing to `order_by` and soft deprecating `sort_by`.

What about keeping the method around and removing all references, tests and usages of it and even adding a deprecation warning?

@icexelloss Thanks for chiming in! The plan is to port nothing back to 3.x for now. Regarding ibis-substrait, how does 3-4 months sound for a cutover to 4.0? In the...

Ideally we can change pyarrow to allow Sequences and Mappings through instead of being so strict about the specific type.

Ah, so this is only implemented for the use case of `ibis.date(thing) -> thing.date()`, extracting the date from a non-date column. We haven't implemented the variadic case of `date`. This...