Christopher Allen
Christopher Allen
Hey @jzyan1999: are you still planning to send us a PR for this? If not I will unassign this issue (though of course you are still welcome to send us...
> If the folder is not in /Volumes, it seems to not be deleted afterwards. That is the normal behaviour for unix `mount`: you have to create the directory (typically...
Can you restructure this as a complete example that runs (but, presumably, generates an error)? Specifically, in "this is my test", you don't specify a value for `condition`.
CI is failing here and on #2228; [comment about this moved to #2228](https://github.com/google/blockly-samples/pull/2228#issuecomment-1979392942) as it looks like that PR will probably be the one that gets merged.
> 1. Separate out [fix(dev-tools): Have runSerializationTestSuite accept Blockly](https://github.com/google/blockly-samples/pull/2229/commits/c453fb78b717c77a1e5a9f59af92ffb8d6dca790) into a different, non-breaking change… That commit is already not a breaking change. Are you thinking of `chore(dev-scripts)!: Remove support acquiring...
1. > So I think you're right that the breaking change to dev-scripts won't necessarily cause all the others to get a new major version. However, any plugin that is...
Note to reviewer: it may be helpful to review this PR commit-by-commit.
[Edited for clarity.] > I will note that doing a breaking change in dev-tools/dev-scripts will cause every other plugin to also get a major version bump. That is surprising. This...
[Comment moved from #2229 as it looks like this one will probably be the one that gets merged.] CI is failing here and in #2229 due to multiple similar test...
Even after modifying `runSerializationTestSuite` to work around the problem caused by multiple copies of `jsdom` being included in each test bundle, one additional test, in `plugins/typed-variable-modal`, is still failing: ```...