dbcsr icon indicating copy to clipboard operation
dbcsr copied to clipboard

Consider to drop -Werror for tests/configs pulling external APIs/frameworks

Open hfp opened this issue 3 months ago • 12 comments

As we pull latest bits/dependencies into tests, our CI is prone to break automatically. For example, some recent ROCm deprecation seems to cause warnings (turned into errors). This may be wanted but if not, -Werror may be disabled for certain configs.

In file included from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13: /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp: In function ‘int c_dbcsr_acc_init()’: /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:30:40: error: ‘hipError_t hipDevicePrimaryCtxRetain(ihipCtx_t**, hipDevice_t)’ is deprecated: This API is marked as deprecated and may not be supported in future releases. For more details please refer https://github.com/ROCm/HIP/blob/develop/docs/reference/deprecated_api_list.md [-Werror=deprecated-declarations] 30 | ACC_DRV_CALL(DevicePrimaryCtxRetain, (&ctx, acc_device)); /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:33:35: note: in definition of macro ‘HIP_API_CALL’ 33 | hipError_t result = ACC(func) args;
| ^~~~ /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:30:3: note: in expansion of macro ‘ACC_DRV_CALL’ 30 | ACC_DRV_CALL(DevicePrimaryCtxRetain, (&ctx, acc_device)); | ^~~~~~~~~~~~ In file included from /opt/rocm-6.1.0/include/hip/hip_runtime.h:70, from /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:13, from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13: /opt/rocm-6.1.0/include/hip/hip_runtime_api.h:5128:12: note: declared here 5128 | hipError_t hipDevicePrimaryCtxRetain(hipCtx_t* pctx, hipDevice_t dev); | ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13: /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp: In function ‘int c_dbcsr_acc_finalize()’: /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:44:41: error: ‘hipError_t hipDevicePrimaryCtxRelease(hipDevice_t)’ is deprecated: This API is marked as deprecated and may not be supported in future releases. For more details please refer https://github.com/ROCm/HIP/blob/develop/docs/reference/deprecated_api_list.md [-Werror=deprecated-declarations] 44 | ACC_DRV_CALL(DevicePrimaryCtxRelease, (acc_device)); /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:33:35: note: in definition of macro ‘HIP_API_CALL’ 33 | hipError_t result = ACC(func) args;
| ^~~~ /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:44:3: note: in expansion of macro ‘ACC_DRV_CALL’ 44 | ACC_DRV_CALL(DevicePrimaryCtxRelease, (acc_device)); | ^~~~~~~~~~~~ In file included from /opt/rocm-6.1.0/include/hip/hip_runtime.h:70, from /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:13, from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13: /opt/rocm-6.1.0/include/hip/hip_runtime_api.h:5112:12: note: declared here 5112 | hipError_t hipDevicePrimaryCtxRelease(hipDevice_t dev); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors

hfp avatar Apr 22 '24 14:04 hfp