dbcsr icon indicating copy to clipboard operation
dbcsr copied to clipboard

Add CMake `PROCESSORS` properties

Open LecrisUT opened this issue 1 year ago • 4 comments

This property will allow to properly parallelize ctest -j calls

LecrisUT avatar Jan 30 '24 09:01 LecrisUT

Can one of the admins verify this patch?

jenkins-cscs avatar Jan 30 '24 09:01 jenkins-cscs

Small note about TEST_MPI_RANKS. It should be fixed to 2 instead of auto in order to better take advantage of ctest parallelization

LecrisUT avatar Jan 30 '24 11:01 LecrisUT

@LecrisUT Thanks for this PR. I like the idea to default the number of ranks to 2. Most of the tests are really intended for max 4 ranks in general... Still, it will be good to provide a way to cap the processors to the max available. I will work on that next week.

alazzaro avatar Feb 09 '24 11:02 alazzaro

Still, it will be good to provide a way to cap the processors to the max available

This is typically done via ctest -j $(nproc)

LecrisUT avatar Feb 09 '24 12:02 LecrisUT

If this PR targets the next release of CP2K/DBCSR, it would be the right time to finish/conclude it.

hfp avatar May 16 '24 11:05 hfp

Seems like I may need this PR for #759. Tests are timing out due to parallelization there

LecrisUT avatar May 17 '24 11:05 LecrisUT

Small note about TEST_MPI_RANKS. It should be fixed to 2 instead of auto in order to better take advantage of ctest parallelization

I've changed the default to be 2, see https://github.com/cp2k/dbcsr/commit/d8116fd92ca336c47cc00e2f15d73443f2b69285

alazzaro avatar Jun 18 '24 20:06 alazzaro