secret-hitler icon indicating copy to clipboard operation
secret-hitler copied to clipboard

Horn Music plays many times

Open ende23r opened this issue 6 years ago • 4 comments

When the horn sound effect plays (I think when the President has the power to kill someone?), it sometimes plays many times in quick succession, creating a cacophony of noise.

ende23r avatar May 25 '18 02:05 ende23r

hmm ok like the president hasn't picked someone to kill yet?

cozuya avatar May 25 '18 03:05 cozuya

Apparently this is still happening with all the different sounds. Not sure how to reproduce it really though.

samfuller01 avatar Aug 05 '20 04:08 samfuller01

Sounds like a setInterval gets registered and doesn't get deregistered on componentUnmount - theoretically shouldn't be that difficult a fix.

Vigasaurus avatar Aug 05 '20 04:08 Vigasaurus

I poked around with this some a while ago and couldn't really find a reason for this. As far as I can tell something is messing up with props in the componentDidUpdate in the Game.jsx file and is causing it to keep replaying the sound.

samfuller01 avatar Sep 23 '20 14:09 samfuller01