secret-hitler
secret-hitler copied to clipboard
Horn Music plays many times
When the horn sound effect plays (I think when the President has the power to kill someone?), it sometimes plays many times in quick succession, creating a cacophony of noise.
hmm ok like the president hasn't picked someone to kill yet?
Apparently this is still happening with all the different sounds. Not sure how to reproduce it really though.
Sounds like a setInterval gets registered and doesn't get deregistered on componentUnmount - theoretically shouldn't be that difficult a fix.
I poked around with this some a while ago and couldn't really find a reason for this. As far as I can tell something is messing up with props in the componentDidUpdate
in the Game.jsx
file and is causing it to keep replaying the sound.