Gili Tzabari

Results 301 comments of Gili Tzabari

Is the code even making use of `configure` anywhere? I can see the code accepting it as a parameter but it doesn't look like it ever gets used. This is...

@owen-m1 Any chance you could add a visual demonstration similar to http://sortablejs.github.io/Sortable/#thresholds showing the balance/trade-offs between the two? Also, I think it might be problematic that one property is specified...

I agree with @florianb that we should keep the tone of the discussion civil. That said, I like @Naheulf's approach of separating indentation and alignment into two separate properties. I'm...

I have personally never seen anyone use tabs for alignment. Have you? Every IDE I've seen defines "smart tabs" as "tabs for indentation, spaces for alignment" because alignment requires 1-character...

Another approach we can consider is creating hierarchical properties for each kind of formatting style. I'm going to use dummy property names so please gloss over that details: ``` alignment=spaces...

The only use-case that is driving me is "smart_tabs". From my perspective I don't really `align_size` at this point. `indent_size` is fine for now as it already specifies the tab...

Per https://maven.apache.org/download.cgi Maven 4.x requires JDK 8. What is needed to move this PR forward?

This should really be the default implementation out-of-the-box. Can this issue be reopened?

@not522 Maybe we could have a built-in pruner that rejects duplicates and rolls back the number of trials by one automatically.