Tatu Saloranta comments

Results 3352 comments of


                                            Tatu Saloranta

Use `CsvSchema.ColumnType.NUMBER` and such to coerce field values from plain `String`s

I am not sure I understand. What exactly is your issue here? Signature that `readValues()` returns?

Use `CsvSchema.ColumnType.NUMBER` and such to coerce field values from plain `String`s

Unfortunately there is currently no support for automatic coercion of types based on Schema: all conversions require target type (POJO properties usually) to work. Originally there was a plan to...

JSON5: Provide a way to read/write a comment using `JsonNode`

Ok. So, it might be possible to write some comments through `JsonNode` by using "raw value" (and at streaming level, `JsonGenerator.writeRaw()` (NOT "rawValue" actually)) but that is definitely cumbersome. But...

JSON5: Provide a way to read/write a comment using `JsonNode`

Unfortunately I don't thing add-on interfaces help a lot with the core issue (or maybe I just don't see it). Support would still need to be added in `JsonNode` implementations....

Always quote strings with leading/trailing spaces in CSV

Does `CsvGenerator.Feature.STRICT_CHECK_FOR_QUOTING` not do that already?

Always quote strings with leading/trailing spaces in CSV

@sfzhi Thank you -- it does sound like there should be a way to force quoting, then; and if not done by default at this point, probably needs to be...

`Arrays.asList()` value deserialization has changed from mutable to immutable in 2.13

I think this would be best expressed in form of unit test, showing how mutability changed. Would it be possible to add it here -- even just couple of lines...

`Arrays.asList()` value deserialization has changed from mutable to immutable in 2.13

Ok, fixed. Due to low risk backported in 2.13 for 2.13.4 release.

[CSV] custom serializer writes unspecified properties of kotlin data class

I think what I would need here is Java-only reproduction, as CSV module can not depend on Kotlin module (and ideally Kotlin module also not on CSV module, even for...

[CSV] custom serializer writes unspecified properties of kotlin data class

Reading the example again, I suspect this actually may be Kotlin module problem: CSV format must include placeholders for all properties detected, so it seems likely that `id` property should...