Tatu Saloranta

Results 3335 comments of Tatu Saloranta

@JacekLach lol. Thanks. Yes. Stupid github auto-completion.

@jcustenborder It is not meant to be used by non-core package itself, so the only reason would be if it needs to be accessed from within another package. If you...

Is this with version 2.10.3? There is also one change to behavior of schema generation in 2.11, so 2.11.0.rc1 (2.11.0 will be released very soon) might have differing handling.

@MichalFoksa sounds like possible nice incremental improvement? Could you please file a separate issue for this specific aspect as there are multiple things that could be improved, and schema generation...

Ok, so, #283 added support for some of `java.time` types. Looks like support for `BigDecimal` could be added similarly, but with separate PR: perhaps generation of `logicalType` going in `AvroMapper`...

Interesting. I assume this should work, as long as schema has such field so looks like a bug to me.

Actually, no. I should have read it more closely: you are generating Avro schema from POJO, and it has no real properties, just any setter/getter. As a result, Avro schema...

@antonymayi Yes, if there was a `Map` it'd work: but these are not identical cases: "any properties" do unwrapping, whereas `Map` is a single named value. I could see possible...

@baharclerode I concur -- interesting note on `@JsonAnySetter`, although that is sort of on path on diminishing returns I guess. I may file a new issue for potential continuation, close...

@baharclerode come to think of it, wouldn't `@JsonAnySetter` already work, as-is? Since logical binding is done by avro codec... I guess there are some cases where it now drops "skippable"...