node-globule icon indicating copy to clipboard operation
node-globule copied to clipboard

Update to use micromatch

Open doowb opened this issue 7 years ago • 1 comments

Description

This PR is to use micromatch instead of minimatch.

This change addresses the performance and safety issues that have been found in minimatch. For more general information on why to use micromatch, this section goes over the features. Also, the braces readme has more information about why it's safer.

Additional information

Using micromatch resolves https://github.com/cowboy/node-globule/pull/25, since micromatch has more complete extglob support. A test has been added for this use case.

You can also close https://github.com/cowboy/node-globule/issues/10, since {ignore: ['**/node_modules/**']} will achieve the desired result.

doowb avatar Dec 22 '17 17:12 doowb

Great work. Would love to see this merged!

idmadj avatar Nov 27 '18 19:11 idmadj