jquery-postmessage icon indicating copy to clipboard operation
jquery-postmessage copied to clipboard

Remove Opera sniff

Open miketaylr opened this issue 14 years ago • 16 comments

SUP BEN.

Opera 9.64 is like, 9 versions old. I know Ryan has a fork that normalizes its old document.postMessage implementation--but I think that's going to help like 0.01% of all Opera users. So....this is easier and won't break any sites or provide a crappy fallback for current Opera users.

miketaylr avatar Oct 20 '11 17:10 miketaylr

Ben, want me to um write a test for this or something?

miketaylr avatar Feb 09 '12 17:02 miketaylr

Beatport.com users can't complete the checkout process because of this sniff now too. :disappointed:

miketaylr avatar Feb 27 '12 03:02 miketaylr

We're patched now at Beatport. Thanks for the fix!

alexmchardy avatar Feb 29 '12 17:02 alexmchardy

I was about to make the same pull request, Opera now supports postMesage.

Ben, are you alive? =)

/JT

jtsoi avatar Mar 21 '12 15:03 jtsoi

+1 on this from me too!

chrisdavidmills avatar May 10 '12 17:05 chrisdavidmills

Yet another +1.

alloy-d avatar May 10 '12 17:05 alloy-d

Another +1 here.

tagawa avatar May 11 '12 05:05 tagawa

And another +1 from me.

andreasbovens avatar May 11 '12 07:05 andreasbovens

for Opera, use

window.addEventListener('message', callback, false)

instead of

window.addEventListener('message', callback, !1)

I checked on opera 12, it doesn't work when we pass !1 as third argument of addEventListener method

freddywang avatar Aug 10 '12 08:08 freddywang

If not removed this "sniffing" statement should be modified for compatibility with jQuery 1.9.x+ as $.browser is deprecated now.

abhishekdev avatar Mar 29 '13 14:03 abhishekdev

:+1:

Calvein avatar Apr 15 '13 02:04 Calvein

:+1:

lukeasrodgers avatar Aug 05 '13 21:08 lukeasrodgers

Further to this I have modified the browser sniff so that it does not fail on jQuery 1.9.x+ and I have added a note to the README to use the jQuery.browser plugin.

damienwhaley avatar Aug 07 '13 05:08 damienwhaley

hi ben, miss u. ❤️

miketaylr avatar Mar 28 '17 00:03 miketaylr

Yesss!

vladikoff avatar Mar 28 '17 16:03 vladikoff

🎂 happy bday PR

buritica avatar Mar 28 '17 16:03 buritica