jquery-bbq icon indicating copy to clipboard operation
jquery-bbq copied to clipboard

release jquery-bbq-v1.3

Open binki opened this issue 12 years ago • 0 comments

The jQuery.fn.hashchange() in jquery-hashchange-v.1.3 is not included in the relatively standard jquery-ba-bbq-1.2.1 minified version. I’m not sure what else has changed in jquery-bbq itself, but to get the new hashchange code, it would be nice to have the user get the hashchange minified version separately from jquery-bbq or for the combined minification to at least have the best version of each plugin.

binki avatar Apr 03 '13 16:04 binki

Maybe it should use window instead?

Anything using Function for evaluating code to global "this" is imho sufficiently far way from any responsible coding standard that I can't consider it.

Perhaps it makes more sense to simply pass window here since this jQuery plugin has no sensible use case outside a browser environment (unlike jQuery core, for example).

For comparison, jQuery core settled on the following https://github.com/jquery/jquery/pull/1476:

typeof window !== "undefined" ? window : this

Krinkle avatar Dec 18 '15 20:12 Krinkle

Oh, 9years ago. No, you shall not set it like is your comment, because that shall guarantee, that you not in binded function, correct way is to create function and return "this". I think eval was made to worship linter.

zba avatar Sep 16 '24 05:09 zba