covid19india-react icon indicating copy to clipboard operation
covid19india-react copied to clipboard

Published 20 hours ago • verified publisher icon covid19india

Change the route when language is changed.

Open manoj30075 opened this issue 4 years ago • 10 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] I want to share a link to my uncle where he can read the page directly in Telugu(LANGUAGE). The problem with the present issue is the route is not changing when language is changed. This is becoming an issue for me to explain to my uncle how to change the language on the website.

Describe the solution you'd like A clear and concise description of what you want to happen. If the language is changed the route(link) has to be changed. So that the link including the language change is sharable.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

manoj30075 avatar May 21 '20 07:05 manoj30075

I would like to /claim this issue.

RisingGeek avatar May 30 '20 15:05 RisingGeek

Hi, fixed a bug #2172 which scrolls to top whenever change the language button is clicked, it might make a better UX and also help ease in site accessibility. Hope it helps. Thanks 😄

navkumar258 avatar Jun 26 '20 17:06 navkumar258

/available

shuklaayush avatar Jul 03 '20 08:07 shuklaayush

This issue is available for contribution.

Please reply "/claim" (without quotes) if you wish to work on this issue.

github-actions[bot] avatar Jul 03 '20 08:07 github-actions[bot]

/claim

RisingGeek avatar Jul 03 '20 09:07 RisingGeek

Thank you @RisingGeek for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

github-actions[bot] avatar Jul 03 '20 09:07 github-actions[bot]

/claim

khpatel8 avatar Jul 27 '20 21:07 khpatel8

Thank you @khpatel8 for claiming this issue! 🎉

Please reference this issue when you submit your Pull Request and make sure you follow the contributing guidelines.

github-actions[bot] avatar Jul 27 '20 21:07 github-actions[bot]

is there a format that you would like to be followed when making a new route for language ?

khpatel8 avatar Jul 28 '20 03:07 khpatel8

what i have implemented so far:

(1) baselink takes you to (2) with default language english (2) baselink/[language name]/ : Home route (3) baselink/[language name]/about : about page (english only as per previous implementation) (4) baselink/blog as usual takes you to blog.covid19india.org

**Do you want me to convert the language name to it's ISO code or just the full name is fine ? **

If this all looks good, I can create a PR. Let me know

khpatel8 avatar Jul 29 '20 04:07 khpatel8