saml-client icon indicating copy to clipboard operation
saml-client copied to clipboard

NameID is treated as required rather than optional

Open OnixGH opened this issue 5 years ago • 0 comments

SamlClient.decodeAndValidateSamlResponse() fails if the response doesn't contain NameID. It seems like the field used to be required, but isn't anymore at the moment.

Although most IDPs probably do send it, or should be configurable to, we currently have no way of accepting responses without NameID, and no way of convincing IDPs outside of our control to change this (since they are apparently sending out a compliant response).

Could the requirement be dropped, perhaps in favor of a warning, or otherwise have some option of disabling the requirement?

See also this thread: https://github.com/onelogin/python-saml/issues/112

OnixGH avatar Jan 28 '20 15:01 OnixGH