cpputest-for-qpcpp icon indicating copy to clipboard operation
cpputest-for-qpcpp copied to clipboard

-Wold-style-cast causing build fail

Open nicwainwright opened this issue 6 months ago • 2 comments

Hey so it looks like the old-style-cast is causing the build to fail since (uint) and (size_t) casts are used.

This is from commit 0b343a6c

Image

I can patch it out of the CMake to make it compile and run, but maybe best to remove the flag or fix the old-style cast usage?

Would you like me to make a MR?

Image

nicwainwright avatar Jun 10 '25 16:06 nicwainwright

@nicwainwright out of curiousity, what is the build environment for this?

SimpleString is in cpputest itself, so can't change that, but happy to resolve others.

Strangely, I do not see these warnings. However, just tried in Ubuntu 24.04, and had to disable my attempt at using cppcheck, as it is stopping the build on a very false positive within QP itself. blah.

mattheweshleman avatar Jun 10 '25 17:06 mattheweshleman

feel free to open a PR, however, I am not seeing an old style cast. The screenshots provided cut the file name, so I guess I might be looking in the wrong files. If you have the exact path and line numbers for those casts, happy to help.

mattheweshleman avatar Jun 10 '25 17:06 mattheweshleman