pcap-file icon indicating copy to clipboard operation
pcap-file copied to clipboard

Make block_common and opt_common public

Open alejandrofsGR opened this issue 1 year ago • 1 comments

This would be useful in order to be able to create CustomBinaryOption instances from custom capture software.

Use cases include recording additional timestamps for a specific packet (for example, hardware timestamp at NIC vs timestamp at CPU).

alejandrofsGR avatar Nov 11 '24 17:11 alejandrofsGR

Hello, I'll do it after the other MR are merged.

courvoif avatar Apr 21 '25 14:04 courvoif

Hi @courvoif , any chance this PR can be merged now?

amorenoz avatar Jun 03 '25 08:06 amorenoz

I don't have the right to push to this PR. I've taken the changes done here and put them here: #49

courvoif avatar Jul 12 '25 17:07 courvoif

For the record I found out that I did have the right to push but the LFS pre-push hook was preventing me to push for an unknown reason. The error was exactly the same as an permission/authentication error.

courvoif avatar Jul 13 '25 10:07 courvoif