coursier icon indicating copy to clipboard operation
coursier copied to clipboard

Check - cache some hash codes

Open alexarchambault opened this issue 11 months ago • 1 comments

Suspicious thing spotted in https://github.com/coursier/coursier/pull/3193. Caching these hash codes (and slightly changing how they're computed along the way) ~doesn't break CI on the current main~ (see below). It should break an obscure test case once https://github.com/coursier/coursier/pull/3193 is there. I'm not sure why yet…

alexarchambault avatar Dec 26 '24 16:12 alexarchambault

So it seems this breaks when using Scala 2.12, but not when using 2.13:

$ ./mill 'tests.jvm[2.12.20].test' "coursier.tests.CentralTests" # fails
$ ./mill 'tests.jvm[2.13.15].test' "coursier.tests.CentralTests" # succeeds

Might involve some undefined order-related behavior when handling sequences and maps…

alexarchambault avatar Dec 26 '24 18:12 alexarchambault