monorepo
monorepo copied to clipboard
counterfactual
Remove external eth_calls by using a JS-based EVM interpreter
Calling eth_call for every applyAction and resolve sucks. It is slow.
We can use a JS-based EVM interpreter instead. https://github.com/ethereumjs/ethereumjs-vm offers a runCode method we could use.
There is a subtle problem which is that for some specific apps we allow view functions (e.g., ETHBalanceRefundApp to observe address(multisigAddress).balance). So, those ones need to use eth_call. Maybe you can observe the ABI of the contract and conditionally use eth_call for those.
Still trying to get v5 into public beta, then I’ll start making the EVM public through its experimental package.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 750.0 DAI (750.0 USD @ $1.0/DAI) attached to it.
- If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $41,591.17 more funded OSS Work available on the Gitcoin Issue Explorer
Yeah, I'd like to specify it better though. Our ideal scenario is that we can take an ethers.Contract and call .functions.<blah> on that object and if blah is a pure function then compute the result locally. @ricmoo mentioned he was working on this, though.
@snario It shows open on Gitcoin. Is it actually open? If it is, I'd like to take it up.
Hey @ricmoo can you apply for work on this one since you're already working on it :)
What is the desired timeline for this task? Keep in mind the ABI would require a runtime bytecode in it to use this feature; I’ve been trying to think of a way to integrate pure functions into the ABI for a while.
One other concern I have is any bug in the VM can result in consensus forks between a channel and the chain. What type of operations will be marked pure?
@ricmoo It is non-blocking for us but a big win for the entire Layer 2 ecosystem.
I think a bug in the VM would be just that, a software error that would cause the state channel states to have been signed incorrectly. I think this is the same problem as a a software error in geth or parity VMs right?
Specifically the interface we care most about is function foo(bytes memory, bytes memory) pure returns (bytes memory) however this feature should support function foo(<anything>...) pure returns (<anything>...).
@snario Any luck with ethereumjs-vm runCall? It should be reliable and kept up-to-date, as its also used by ganache.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 4 months, 3 weeks ago. Please review their action plans below:
1) stevenjnpearce has been approved to start work.
I've already got an implementation working; will write some tests for it and submit.
Learn more on the Gitcoin Issue Details page.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work for 750.0 DAI (750.0 USD @ $1.0/DAI) has been submitted by:
@ceresstation please take a look at the submitted work:
- PR by @StevenJNPearce
- Learn more on the Gitcoin Issue Details page
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $84,498.32 more funded OSS Work available on the Gitcoin Issue Explorer
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
The funding of 750.0 DAI (750.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @StevenJNPearce.
Thanks to @hosseinnzmi for their crowdfunded contributions to this bounty.
- Learn more on the Gitcoin Issue Details page
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $135,494.90 more funded OSS Work available on the Gitcoin Issue Explorer