monorepo icon indicating copy to clipboard operation
monorepo copied to clipboard

Published 20 hours ago • verified publisher icon counterfactual

[greenboard] Adds Deposit scenario

Open joelalejandro opened this issue 5 years ago • 3 comments

This PR implements the following scenarios:

A registered user should be able to make deposits with ETH. A registered user should be able to make deposits with ERC20.

Contributes to #1852.

joelalejandro avatar Aug 05 '19 21:08 joelalejandro

Waiting on #2102 to be merged to prevent test selector conflicts.

joelalejandro avatar Aug 07 '19 20:08 joelalejandro

@spersico can you pick up where I left off on this PR? It'd be great to add a second flow where the user attempts to deposit with an ERC20 token instead of ETH.

Don't worry too much about the conflicts; I'm 0x056ba3d73af34f0000 sure that those are related to selector names and legacy "deposit" references in Withdraw.

joelalejandro avatar Aug 14 '19 14:08 joelalejandro

Yes! Sure!

El mié., 14 de agosto de 2019 11:25, Joel Alejandro Villarreal Bertoldi < [email protected]> escribió:

@spersico https://github.com/spersico can you pick up where I left off on this PR? It'd be great to add a second flow where the user attempts to deposit with an ERC20 token instead of ETH.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/counterfactual/monorepo/pull/2135?email_source=notifications&email_token=ACQEDTLHWYAK5J5NKA7UKVDQEQIULA5CNFSM4IJPFOZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4I6XIY#issuecomment-521268131, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQEDTPAWRWE4BSH3VNVZ2TQEQIULANCNFSM4IJPFOZA .

spersico avatar Aug 14 '19 14:08 spersico