monorepo icon indicating copy to clipboard operation
monorepo copied to clipboard

Why set latestNonce to NONCE_EXPIRY in the lockCommitment during uninstall-vitual-app-protocol?

Open skyinglyh1 opened this issue 6 years ago • 0 comments

Why you guys lock the app nonce to the NONCE_EXPIRY=65536 when uninstalling the virtual app channel?

From my perspective, lock is necessary in order to set up the consensusthat initiatingXpub and respondingXpub and intermediaryXpub agree that 'the virtual app channel is about to be closed'.

But why set the nonce to the max value?

https://github.com/counterfactual/monorepo/blob/33560af357574159b52f1d171f3462cec108b565/packages/node/src/protocol/uninstall-virtual-app.ts#L272

https://github.com/counterfactual/monorepo/blob/33560af357574159b52f1d171f3462cec108b565/packages/node/src/models/state-channel.ts#L351

skyinglyh1 avatar Jun 05 '19 04:06 skyinglyh1