certbot-dns-schlundtech TOTP via PyOTP

Hi,

I did some changes for 2FA. Now it's using PyOTP to generate the access token. I tested it with my Schlundtech account via the Docker version. I also edited the setup.py install_requiremnts, but I didn't test it his way. Is there a better way for Docker than RUN pip install for PyOTP? This is my first (and probably last) Python program, so I didn't change the parameter name for TOKEN, as I didn't wont to break anything. Maybe the name is not the best anymore.

I tested it a few times with my account and also with more than one domain via the -d option. (domain1.com, *.domain1.com, domain2.com, *.domain2.com).

Let me know, if you need some further testing or some changes.

Best regards from Ruhrpott Stefan

Apr 01 '23 21:04 stefango79

I cleaned up the Dockerfile. PIP install was obsolete. Pretty sure it works as expected now.

Apr 12 '23 15:04 stefango79

@couchtyp this looks much more in line with what I would expect from 2fa support. Without something like this, I need to always have an external mechanism that updates the configuration file all the time before invoking certbot, which is quite annoying.

Any reason you don't want to merge this?

Jun 06 '23 06:06 dwt